Group related addons #1428
Draft
Group related addons #1428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have 6 rook addons and 4 ocm addons. Keeping them in separate
directories makes it harder to navigate and understand the code, and
lead to horrible duplication of URLs and versions that makes upgrading
addons a pain.
This change is the first step, grouping together rook and ocm addons:
$ tree -L 1 addons/rook/
addons/rook/
├── cephfs
├── cluster
├── operator
├── pool
├── rbd-mirror
└── toolbox
$ tree -L 1 addons/ocm/
addons/ocm/
├── cluster
├── controller
└── hub
Signed-off-by: Nir Soffer <nsoffer@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Group rook-* and ocm-* addons under rook/ and ocm/ directories. This will helps to navigate and understand the code, and will allow eliminating duplication in addons.