Return information only if primary VRG is found during initial deploy… #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ployment check For initial deployment, when checking for deployed VRGs on the managed clusters, only return the cluster if the primary VRG on it is found, otherwise, return 'not found' Signed-off-by: Benamar Mekhissi <bmekhiss@ibm.com>
ShyamsundarR
approved these changes
Jun 13, 2024
|
Tested older behavior in drenv with CephFS/Volsync backed volumes, and post deploy if preferred cluster is down and MCV reports errors the rdspec is cleared out in Secondary (had to manually edit MCV status to report false, as upstream MCV status does not change if cluster is down). Patched and repeated tests as above, and rdspec is retained. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed this PR with @ShyamsundarR and concluded that it is more complex and poses a risk of introducing hidden bugs. Therefore, we will leave it open for future versions. For version 4.16, we intend to implement a straightforward fix that addresses the specific instance of the issue we have identified. A comprehensive, global solution will be considered for later updates.
When the primary cluster is down and the workload is in the initial deployment that is targeted for volsync, the DRPC might mistakenly think the VRG on the secondary cluster is the primary one. This code hasn't changed since VolSync was introduced. The original code expected only one primary VRG between the two clusters. The fix is straightforward: for the initial deployment, only return the cluster if the primary VRG is found; otherwise, return
not found.