Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing secret propagation from manifests to policy #1471

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

abhijeet219
Copy link
Member

@abhijeet219 abhijeet219 commented Jun 24, 2024

This PR contains following changes:

  • Changing local secrets to k8s secret.
  • Removal of secrets from drCluster manifestwork.
  • Deploying secrets through drpolicy.

Currently clusterRoles and Rolebindings corresponding to vrg, olm, mmode
and drClusterConfig are being deployed through drcluster manifests.
Changing that secret propagation to be handled via policy.

  • Updating unit tests to accomdate changes.

@abhijeet219 abhijeet219 force-pushed the secret-propagation branch 3 times, most recently from 8c6122e to eb41cd3 Compare June 27, 2024 14:24
@abhijeet219 abhijeet219 force-pushed the secret-propagation branch 3 times, most recently from 05cb432 to d1ba588 Compare July 15, 2024 14:50
@abhijeet219 abhijeet219 force-pushed the secret-propagation branch 3 times, most recently from 49a7d63 to 6ebebce Compare July 30, 2024 14:20
@abhijeet219 abhijeet219 marked this pull request as ready for review July 31, 2024 05:51
Copy link
Contributor

@asn1809 asn1809 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@abhijeet219 abhijeet219 force-pushed the secret-propagation branch 5 times, most recently from 53636e4 to 4daca2c Compare August 12, 2024 09:00
Signed-off-by: Abhijeet Shakya <abhijeetshakya21@gmail.com>
Currently clusterRoles and Rolebindings corresponding to vrg,
olm and mmode are being deployed through manifests. Changing
that secret propagation to be handled via policy.

Signed-off-by: Abhijeet Shakya <abhijeetshakya21@gmail.com>
Signed-off-by: Abhijeet Shakya <abhijeetshakya21@gmail.com>
Signed-off-by: Abhijeet Shakya <abhijeetshakya21@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants