Enable DRPC Consistency Groups Using an Annotation #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both annotations and the DRPC spec allow us to enable consistency groups (CG) on a per-DRPC basis, providing more granular control compared to a global configuration. However, we chose to use annotations instead of modifying the DRPC spec to prepare for the future full use of CG. As CG usage matures, we will gradually phase out non-CG snapshotting and replication. Using an annotation also makes it easier to remove for backward compatibility. Signed-off-by: Benamar Mekhissi <bmekhiss@ibm.com>
youhangwang
approved these changes
Jul 19, 2024
|
/lgtm |
ShyamsundarR
approved these changes
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both, annotation and the DRPC spec allow us to enable consistency groups (CG) per-DRPC basis, providing more granular control than a global configuration. However, we chose to use an annotation instead of modifying the DRPC spec to prepare for the future full use of CG. As CG usage matures, we will gradually phase out non-CG snapshotting and replication. Using an annotation also makes it easier to remove for backward compatibility.
Usage: