Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generalized geodesic distance and notable vertex prescription #69

Merged
merged 19 commits into from
Nov 24, 2024
Merged

Generalized geodesic distance and notable vertex prescription #69

merged 19 commits into from
Nov 24, 2024

Conversation

ctlee
Copy link
Collaborator

@ctlee ctlee commented Nov 22, 2024 •
edited
Loading

Description

Add functionality for more flexible creation of functions defining notable vertices in python.

Todos

Notable points that this PR has either accomplished or will accomplish.

  • Add a generalized geodesic distance calculation
  • Expose generalized geodesic distance calculation in pymem3dg
  • Add convenience functions to geometry (isBoundary, nVertices, etc...)

Status

  • Ready to go

ctlee added 4 commits November 21, 2024 18:42
@ctlee
feat: geodesic distance calculations relative to user defined vertices
1028c68 
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
@ctlee
fix: compute geodesic distance const correctness
05784af 
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
@ctlee
fix: propagate changes to notable vertex finder
d9c9cd4 
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
@ctlee
fix: missing cached geodesic distance side effect
519e9af 
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
@ctlee ctlee requested a review from suikarum1 November 22, 2024 22:53
ctlee added 15 commits November 22, 2024 15:54
@ctlee
ci: try unlink pkg-config
edf8671 
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
@ctlee
ci: change brew update
52b230f 
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
@ctlee
ci: switch back
5be6309 
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
@ctlee
build: avoid building both static and dynamic libmem3dg
dddec08 
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
@ctlee
build: Add fpic for geometry central
e0a8d0d 
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
@ctlee
ci: Add back update brew
ad52082 
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
@ctlee
ci: add brew upgrade
1cafd5c 
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
@ctlee
ci: try macos-15
e707741 
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
@ctlee
ci: Unlink pkg-config
3818ef1 
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
@ctlee
ci: try conda for macos
1e4caca 
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
@ctlee
ci: fix conda python version
554d16d 
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
@ctlee
ci: remove spurious channel
7d6ab12 
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
@ctlee
ci: add conda to cmake-prefix
6949236 
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
@ctlee
build: do not search for netcdf
807609e 
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
@ctlee
Remove macos building
1299ef9 
Signed-off-by: Christopher T. Lee <ctlee@ucsd.edu>
@ctlee ctlee merged commit fedb38e into development Nov 24, 2024
4 checks passed
@ctlee ctlee deleted the generalized-geodesic-distance branch December 5, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suikarum1 suikarum1 Awaiting requested review from suikarum1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ctlee