fix: base32 for ipfs:// urls and cidv1 everywhere #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- make POST return a base32 encoded cidv1. - default to using cidv1 everywhere. - update to use the new ipfs-core module. base36 is the right thing to use to respect the max authority length for ipns:// scheme urls. The assumption is folks should use base32 for CIDs in ipfs:// scheme urls, and it's the default output for cidv1. The new ipfs-core modules has the same api as the `ipfs` module but doesn't include the cli and http-server code with it. At time of writing the tests pass apart from the last one, which hangs. I think it's due to an unrelated bug ipfs/js-ipfs#3692 License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
|
I'll chase down ipfs/js-ipfs#3692 when i get time and see if I can get that unrelated test hang fixed. |
RangerMauve
requested changes
May 18, 2021
There was a problem hiding this comment.
Thank you for the PR @olizilla !
Just had some questions about the migration to ipfs-core and some clarification for the base32 stuff. 😁
I'll look into the test more just before merging.
|
Thanks for the clarifications, @lidel! |
|
Published in 2.0.0 since this changes how URLs work. Thanks again for the PR and thanks @lidel for the clarification. |
|
🎉 what a nice thread to wake up to! Thanks @lidel and lovely work on this module @RangerMauve ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
base36 is the right thing to use to respect the max authority length for ipns:// scheme urls.
The assumption is folks should use base32 for CIDs in ipfs:// scheme urls, and it's the default output for cidv1.
The new ipfs-core modules has the same api as the
ipfsmodule but doesn't include the cli and http-server code with it.At time of writing the tests pass apart from the last one, which hangs. I think it's due to an unrelated bug ipfs/js-ipfs#3692
License: MIT
Signed-off-by: Oli Evans oli@tableflip.io