Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subject encoding now part of sendmailR #133

Merged
merged 1 commit into from
Jan 4, 2023
Merged

Subject encoding now part of sendmailR #133

merged 1 commit into from
Jan 4, 2023

Conversation

areedv
Copy link
Contributor

@areedv areedv commented Dec 13, 2022

Previous problems with none ASCII characters in subject header field not showing in email clients is now taken care of by sendmailR, see changes in its version 1.3-1. Hence, rapbase no longer have to deal with this issue and one out of too many lines under Imports can be removed 🎉

@areedv areedv requested a review from kevinthon December 13, 2022 13:51
@codecov
Copy link

codecov bot commented Dec 13, 2022

Codecov Report

Base: 96.03% // Head: 96.03% // No change to project coverage 👍

Coverage data is based on head (aec223e) compared to base (746c117).
Patch has no changes to coverable lines.

❗ Current head aec223e differs from pull request most recent head 5d1262d. Consider uploading reports for the commit 5d1262d to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #133   +/-   ##
=======================================
  Coverage   96.03%   96.03%           
=======================================
  Files          16       16           
  Lines        1236     1236           
=======================================
  Hits         1187     1187           
  Misses         49       49           
Impacted Files Coverage Δ
R/sendEmail.R 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@kevinthon kevinthon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ser fint ut, har ikke mulighet til å teste koden.

@kevinthon kevinthon closed this Jan 3, 2023
@kevinthon kevinthon reopened this Jan 3, 2023
@areedv areedv merged commit a50a1c7 into master Jan 4, 2023
@areedv areedv deleted the bye-base64enc branch January 4, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants