Update dbConnection.R - Require encryption #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Require SSL connection to mysql database, but do not verify certificate
arnfinn
reviewed
Jun 5, 2024
R/dbConnection.R
Outdated
| @@ -29,7 +29,9 @@ rapOpenDbConnection <- function(registryName, dbType = "mysql") { | |||
| host = conf$host, | |||
| user = conf$user, | |||
| password = conf$pass, | |||
| bigint = "integer" | |||
| bigint = "integer", | |||
| client.flag = CLIENT_SSL, # Request SSL connection | |||
There was a problem hiding this comment.
CLIENT_SSL blir her tolket som et objekt eller variabel i R, som ikke finnes og vil derfor feile. Mulig client.flag=2048 vil fungere? Fant noe her: https://www.github.com/r-dbi/RMariaDB/issues/151
There was a problem hiding this comment.
Byttet den til 2048.
Constant CLIENT_SSL does not exist. Using 2048 instead.
|
Jeg tar med meg @kevinthon og tester det ut på test-serveren på fredag. |
|
Lurer på om vi skulle ha tatt med en parameter på den mysqldump-greia også slik at export av databaser også fungerer. |
|
Jeg har slått de to PR sammen i #164, også for å kunne teste i test-miljøet. |
arnfinn
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kan dere teste om dette slår på kryptering på mysql-tilkoblinger, og om det fungerer både mot gamle mysql5-databaser og nye mysql8-databaser? Jeg har ikke mulighet til å teste selv.