Les autoreport fra db som tabell #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fremdeles en del jobb som gjenstår...
Satser på at den kun skal lese tabellen. Ikke oppdatere tabellen.
Tabell som vises i autoreport-fanen
Jeg tror ikke den fungerer enda
arnfinn
force-pushed
the
autoreport_db
branch
from
1a4849b to
3939ad6
Compare
Ble veldig mye støy under testing, blant annet
arnfinn
force-pushed
the
autoreport_db
branch
from
acebfd3 to
f6abf85
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #192 +/- ##
==========================================
- Coverage 92.64% 89.85% -2.79%
==========================================
Files 17 17
Lines 1794 1903 +109
==========================================
+ Hits 1662 1710 +48
- Misses 132 193 +61 ☔ View full report in Codecov by Sentry. |
arnfinn
force-pushed
the
autoreport_db
branch
from
ccc41ce to
06e0101
Compare
arnfinn
commented
Dec 18, 2024
| dplyr::mutate(dplyr::across(dplyr::everything(), as.character)) | ||
| for (element in config) { | ||
| for (email in element$email) { | ||
| dataframe <- dataframe |> tibble::add_row( |
There was a problem hiding this comment.
Bytt til dplyr::bind_row?
arnfinn
commented
Dec 18, 2024
| rd <- rd[!ind] | ||
| writeAutoReportData(config = rd) | ||
| } else if (target == "db") { | ||
| query <- paste0('DELETE FROM autoreport WHERE id = "', autoReportId, '";') |
There was a problem hiding this comment.
hardkodet tabell-navn?
arnfinn
commented
Dec 18, 2024
| writeAutoReportData(config = rd) | ||
| } else if (target == "db") { | ||
| query <- paste0('DELETE FROM autoreport WHERE id = "', autoReportId, '";') | ||
| dbConnect <- rapOpenDbConnection("autoreport") |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Har fått den til å fungere sammen med nordicscir og ablanor.