Bug: columns mixed up with emphasize.strong.cols

[zkamvar]

Your version of pander is awesome and has helped me a lot with my reports, but there is a problem with the argument emphasize.strong.cols in the pandoc.table() function and I thought I should bring it to your attention. If the user specifies more than one column, the result is that the columns are mixed up. Example below:

---

library(devtools)
install_github('pander', 'Rapporter')
ex <- matrix(1:100, 10, 10)
pandoc.table(ex, style='rmarkdown')
pandoc.table(ex, style='rmarkdown', emphasize.strong.cols = 2:3)

You can see the differences between the two tables below:

1	11	21	31	41	51	61	71	81	91
2	12	22	32	42	52	62	72	82	92
3	13	23	33	43	53	63	73	83	93
4	14	24	34	44	54	64	74	84	94
5	15	25	35	45	55	65	75	85	95
6	16	26	36	46	56	66	76	86	96
7	17	27	37	47	57	67	77	87	97
8	18	28	38	48	58	68	78	88	98
9	19	29	39	49	59	69	79	89	99
10	20	30	40	50	60	70	80	90	100

1	11	16	31	41	51	61	71	81	91
2	21	26	32	42	52	62	72	82	92
3	12	17	33	43	53	63	73	83	93
4	22	27	34	44	54	64	74	84	94
5	13	18	35	45	55	65	75	85	95
6	23	28	36	46	56	66	76	86	96
7	14	19	37	47	57	67	77	87	97
8	24	29	38	48	58	68	78	88	98
9	15	20	39	49	59	69	79	89	99
10	25	30	40	50	60	70	80	90	100

This is also observed with data frames.

[daroczig]

Thank you very much for reporting this bug and also giving details with a reproducible minimal example.
I hope this is fixed with the above referenced commit, but please verify.

[zkamvar]

Verification that it works with given examples in multiple columns. Unfortunately it has brought up another bug:

> ex <- matrix(1:100, 10, 10)
> pandoc.table(data.frame(ex), style='rmarkdown', emphasize.strong.cols = 2)
Error in `[<-.data.frame`(`*tmp*`, , emphasize.strong.cols, value = c("**11**",  : 
  replacement has 1 row, data has 10

This is only a problem when a single column is selected. Would a possible solution be to transpose only if the length of emphasize.cols is greater than 1?

[daroczig]

Sorry for such lame "fix" yesterday night, I should have guessed that a quickfix like that would not work at 3am :)
Even the automated tests showed that something is wrong: https://travis-ci.org/Rapporter/pander/builds/7089983

I've just pushed another commit that should resolve this issue. Please verify and feel free to reopen the issue if the problem would persist.

[zkamvar]

Fix verified. Thanks!

[daroczig]

I am really happy to hear that, thank you very much for reporting back.