Tests for different S3 methods #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romantseg
changed the title
|
@daroczig, I think I am done with tests for different S3 methods. Should I just merge it? |
| pandoc.table(res, caption = caption, ...) | ||
|
|
||
There was a problem hiding this comment.
Can you please also remove the white space from the empty lines? My future commits would automatically revert this, so we might end up adding and removing white space all the time.
|
Otherwise it looks OK and extremely useful, thank you. After fixing the above mentioned small code style issues, can you please merge? |
|
@daroczig I fixed the style issues and after some more thinking removed exclusions |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More test cases for CrossTable (aslo one small fix), coxph, clogit, ts