-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Queue command format and Auto-Announce feature #71
base: master
Are you sure you want to change the base?
Conversation
It's now more compact and provides more info
Queueing tweaks
This PR also resolves issue #40. I'm not well practiced in contributing the code I write, so let me know if you need anything from me @Raptor123471. |
I have not had a chance to run this yet but it looks great. My only suggestion right now is that the auto announce configuration in |
Yeah I can do that. I was little unclear about how settings.py is organized, but I've got some time this afternoon to work on it. |
I did the move from the config to settings.py, and I resolved the merge conflicts. However, it seems like an existing settings.json value doesn't actually take the new setting until you run |
That's a mistake on my part where the missing keys are found and set in memory but never written to disk in the 'upgrade' function. I will push the fix and then we can get this PR merged. Check out #72 . I'm going to test it some more when I am home. |
@@ -327,6 +334,7 @@ async def timeout_handler(self): | |||
await self.udisconnect() | |||
|
|||
async def uconnect(self, ctx): | |||
self.ctx = ctx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When the setting start_voice_channel
is set it bypasses uconnect() which will have ctx = none
. See line 71 and 79 in run.py
. For this feature to work when using these settings uconnect() would need to be reworked to accept an optional voice_channel argument for use in run.py
and for line 71 & 79 to use uconnect().
Co-authored-by: Raptor123471 <raptor123471@gmail.com>
I did a reformat on the queue command to make it more compact and to give a bit more info (such as playtimes).
Looks like this:
I also added a configurable feature that auto-announces when a new song starts playing. Useful for people to see what's on deck at a glance without having to do
$np