Skip to content

Commit

Permalink
[ENG-712] Fix dependency install failures on windows (#150)
Browse files Browse the repository at this point in the history
* prevent race condition in poetry build

* update makefile
  • Loading branch information
tabergma committed Dec 21, 2023
1 parent fa00c49 commit ecdd8be
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 1 deletion.
6 changes: 6 additions & 0 deletions .github/workflows/continous-integration.yml
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,12 @@ jobs:
run: |
poetry self add setuptools
- name: Prevent race condition in poetry build
# More context about race condition during poetry build can be found here:
# https://github.com/python-poetry/poetry/issues/7611#issuecomment-1747836233
run: |
poetry config installer.max-workers 1
- name: Load Poetry Cached Libraries ⬇
id: cache-poetry
if: needs.changes.outputs.backend == 'true'
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ prepare-tests-windows:
# It will retry the installation 5 times if it fails
# See: https://github.com/actions/virtual-environments/blob/main/images/win/scripts/ImageHelpers/ChocoHelpers.ps1
prepare-tests-windows-gha:
powershell -command "Choco-Install wget graphviz"
powershell -command "Install-ChocoPackage wget graphviz"

test: clean
# OMP_NUM_THREADS can improve overall performance using one thread by process (on tensorflow), avoiding overload
Expand Down
1 change: 1 addition & 0 deletions changelog/712.misc.md
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Prevent race condition in poetry build to fix dependency install failures on windows.

0 comments on commit ecdd8be

Please sign in to comment.