Skip to content

Commit

Permalink
[ENG-597] Increase minimum compatible version (#12929)
Browse files Browse the repository at this point in the history
* Catch KeyError when running the graph.

* increase minimum compatibile version to 3.7.0b3

* update model version in test

* use constant for minimal compatible version

* add changelog

* remove changelog as it is not needed

* Update error message.
  • Loading branch information
tabergma authored Oct 26, 2023
1 parent f71a675 commit ed35201
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 2 deletions.
2 changes: 1 addition & 1 deletion rasa/constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
CONFIG_TELEMETRY_ENABLED = "enabled"
CONFIG_TELEMETRY_DATE = "date"

MINIMUM_COMPATIBLE_VERSION = "3.5.0"
MINIMUM_COMPATIBLE_VERSION = "3.7.0b3"

GLOBAL_USER_CONFIG_PATH = os.path.expanduser("~/.config/rasa/global.yml")

Expand Down
6 changes: 6 additions & 0 deletions rasa/engine/runner/dask.py
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,12 @@ def run(
try:
dask_result = dask.get(run_graph, run_targets)
return dict(dask_result)
except KeyError as e:
raise GraphRunError(
f"Could not find key {e} in the graph. Error running runner. "
f"Please check that you are running bot developed with CALM instead "
f"of bot developed with previous version of dialog management (DM1)."
) from e
except RuntimeError as e:
raise GraphRunError("Error running runner.") from e

Expand Down
4 changes: 3 additions & 1 deletion tests/engine/storage/test_local_model_storage.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,8 +95,10 @@ def test_read_long_resource_names_windows(
tmp_path_factory: TempPathFactory,
domain: Domain,
):
from rasa.constants import MINIMUM_COMPATIBLE_VERSION

model_dir = tmp_path_factory.mktemp("model_dir")
version = "3.5.0"
version = MINIMUM_COMPATIBLE_VERSION

# full path length > 260 chars
# but each component of the path needs to be below 255 chars
Expand Down

0 comments on commit ed35201

Please sign in to comment.