-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rasa data validate should warn when checkpoints create loops in stories #10925
Comments
Exalate commented: melindaloubser1 commented: May be related to #7985 |
Exalate commented: emysdias commented: hey, I would like to try this issue! |
Exalate commented: emysdias commented: he is going to help me @WashingtonBispo |
Exalate commented: emysdias commented: Whick is better to show, checkpoints or the story that is causing? @hsm207 |
Exalate commented: emysdias commented: The pull request: #10971 |
➤ Maxime Verger commented: 💡 Heads up! We're moving issues to Jira: https://rasa-open-source.atlassian.net/browse/OSS. From now on, this Jira board is the place where you can browse (without an account) and create issues (you'll need a free Jira account for that). This GitHub issue has already been migrated to Jira and will be closed on January 9th, 2023. Do not forget to subscribe to the corresponding Jira issue! ➡️ More information in the forum: https://forum.rasa.com/t/migration-of-rasa-oss-issues-to-jira/56569. |
What problem are you trying to solve?
Users may accidentally create circular logic in stories using checkpoints.
rasa data validate
should flag this if it occurs.What's your suggested solution?
rasa data validate
throws a warning mentioning which checkpoints caused the loopExamples (if relevant)
For example, these stories:
version: "2.0"
stories:
story: happy path 1
steps:
intent: greet
action: utter_greet
checkpoint: cp_a
story: happy path 2
steps:
checkpoint: cp_a
intent: mood_great
action: utter_happy
story: sad path 1a
steps:
checkpoint: cp_a
intent: mood_unhappy
action: utter_cheer_up
action: utter_did_that_help
checkpoint: cp_b
story: sad path 1b
steps:
checkpoint: cp_b
intent: affirm
action: utter_happy
checkpoint: cp_a
story: sad path 1b
steps:
checkpoint: cp_b
intent: deny
action: utter_goodbye
creates a loop as shown in this diagram:
Is anything blocking this from being implemented? (if relevant)
No response
Definition of Done
rasa data validate
throws a warning mentioning which checkpoints caused the loopThe text was updated successfully, but these errors were encountered: