Add check loop def

[emysdias]

Co-authored-by: WashingtonBispo juniorbispo515@gmail.com

#10925

Proposed changes:

file stories.yml to test

version: "3.0"

stories:

- story: greet path
  steps:
  - intent: greet
  - action: utter_greet
  - checkpoint: cp_a

- story: cp_a1
  steps:
  - checkpoint: cp_a
  - intent: movies
  - action: utter_movies

- story: cp_a2
  steps:
  - checkpoint: cp_a
  - intent: deny
  - action: utter_cheer_up
  - checkpoint: cp_b

- story: cp_b1
  steps:
  - checkpoint: cp_b
  - intent: affirm
  - action: utter_cheer_up
  - checkpoint: cp_a
  

- story: sad path 1
  steps:
  - intent: greet
  - action: utter_greet
  - intent: mood_unhappy
  - action: utter_cheer_up
  - action: utter_did_that_help
  - intent: affirm
  - action: utter_happy

- story: sad path 2
  steps:
  - intent: greet
  - action: utter_greet
  - intent: mood_unhappy
  - action: utter_cheer_up
  - action: utter_did_that_help
  - intent: deny
  - action: utter_goodbye

The warning:

Status (please check what you already did):

• added some tests for the functionality
• updated the documentation
• updated the changelog (please check changelog for instructions)
• reformat files using black (please check Readme for instructions)

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ emysdias
❌ itallogravina
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[hsm207]

I don't understand how to interpret cp_b => cp_a is causing a loop. I'd like to quickly identify which stories are causing the loop just by reading the warning, similar to how the warning is when rasa data validate found conflicting stories.

[emysdias]

I don't understand how to interpret cp_b => cp_a is causing a loop. I'd like to quickly identify which stories are causing the loop just by reading the warning, similar to how the warning is when rasa data validate found conflicting stories.

I changed the message

[losterloh]

The code from here seems to also be incorporated into #10984. It may make sense to get this PR here merged first and then rebase #10984 against main.

Copied from #10984:

The verify_loop_in_intents method is hard to read, and lacking tests.
We suggest adding tests and restructuring the method; for instance, splitting it into several sub-methods could improve readability, as will the presence of tests.

As the logic is a bit more on the complex side, adding tests here is crucial.