Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python 3 support #68

Closed
amn41 opened this issue Dec 18, 2016 · 7 comments
Closed

python 3 support #68

amn41 opened this issue Dec 18, 2016 · 7 comments
Assignees
Labels
type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR

Comments

@amn41
Copy link
Contributor

amn41 commented Dec 18, 2016

Currently code doesn't work with python 3.

@amn41 amn41 added type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR help wanted labels Dec 18, 2016
@devenbhooshan
Copy link

Hello guys. Kudos for the launch.

How much effort is needed to resolve this issue ?
What do you guys think?

@HintikkaKimmo
Copy link

HintikkaKimmo commented Dec 20, 2016

Just find the project and first great job. I've been looking for something like this. On the issue, I might be able to help. Progressbar surely does not work in python3 but there is Python3 fork EDIT fork not been updated in 4 years... maybe progressbar2 3.11.0 instead beside that let's see what happens when I run 2to3 on the project. I am not 100% if I have time this but here is a fork https://github.com/HintikkaKimmo/rasa_nlu , I make pull once I get it to work, right now its pile of type errors...

@HintikkaKimmo
Copy link

Ok it's now running on Python 3.5.2 but bit of a hack

@HintikkaKimmo
Copy link

Could someone give a little direction here, Admittedly I only spend about an hour to migrate a rather sizable project and got it running (2 tests are still failing due to type issues). However, my quick fork wouldn't work with Python 2.7, because I did not write backward compatible way and one of the dependencies progressbar was changed to progressbar2. Is there a plan to make the whole project run on both python versions?

If that is the case I can start to contribute small commits file by file, but I have no idea what to do with progressbar and how to make it handle byte data allowing Python2 to still understood what is happening.

@amn41
Copy link
Contributor Author

amn41 commented Dec 21, 2016

Hi Kimmo, thanks very much for looking into this. We can replace progressbar with tqdm . I will try to find someone who can help make the code cross-compatible as well.

@razeone
Copy link

razeone commented Feb 10, 2017

Is there any branch, issues, or something to help with?

@amn41
Copy link
Contributor Author

amn41 commented Mar 20, 2017

@twerkmeister FYI please branch from pipeline not master

@tmbo tmbo removed the help wanted label Mar 22, 2017
taytzehao pushed a commit to taytzehao/rasa that referenced this issue Jul 14, 2023
feat: support branches as GITHUB_REF
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:enhancement ✨ Additions of new features or changes to existing ones, should be doable in a single PR
Projects
None yet
Development

No branches or pull requests

6 participants