Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some grammar errors and redundant words #11984

Merged
merged 2 commits into from
Feb 6, 2023

Conversation

italovinicius18
Copy link
Contributor

Co-authored-by: IanFPFerreira ianfillipe@gmail.com
Co-authored-by: guilhermemoraisr guilhermemoraisr@gmail.com

Proposed changes:

  • There were words and spaces that were duplicated and some wrong syntax that was corrected

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

Co-authored-by: IanFPFerreira <ianfillipe@gmail.com>
Co-authored-by: guilhermemoraisr <guilhermemoraisr@gmail.com>
@italovinicius18
Copy link
Contributor Author

@m-vdb I continued the work on the errors related to this issue #10954 and reviewed the docs again for errors, so I am making this PR, because some errors passed me by

Copy link
Collaborator

@m-vdb m-vdb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @PedroLucasCM for fixing the docs 🙌🏻 I think there were 2 mistakes, can you address them?

docs/docs/action-server/actions.mdx Outdated Show resolved Hide resolved
docs/docs/action-server/knowledge-base-actions.mdx Outdated Show resolved Hide resolved
@PedroLucasCM
Copy link
Contributor

Thanks a lot @PedroLucasCM for fixing the docs 🙌🏻 I think there were 2 mistakes, can you address them?

Hey @m-vdb I think you mistook me for @italovinicius18 😅 we're on the same team though and already warned him

@m-vdb
Copy link
Collaborator

m-vdb commented Feb 1, 2023

oups 😅

@italovinicius18 italovinicius18 requested a review from m-vdb February 4, 2023 00:49
@m-vdb m-vdb merged commit d89a7d4 into RasaHQ:main Feb 6, 2023
@m-vdb
Copy link
Collaborator

m-vdb commented Feb 6, 2023

Thanks a lot @italovinicius18 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants