Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add constraint for websockets #12238

Merged
merged 5 commits into from
Apr 5, 2023
Merged

add constraint for websockets #12238

merged 5 commits into from
Apr 5, 2023

Conversation

vcidst
Copy link
Contributor

@vcidst vcidst commented Apr 4, 2023

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@vcidst vcidst requested a review from radovanZRasa April 4, 2023 15:07
poetry.lock Outdated Show resolved Hide resolved
Copy link
Member

@ancalita ancalita left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vcidst Could you please add a changelog of type misc so that both us and CSE track this change?

@vcidst
Copy link
Contributor Author

vcidst commented Apr 5, 2023

@ancalita done, does that mean the CI will run again? 😞😨

@ancalita
Copy link
Member

ancalita commented Apr 5, 2023

@ancalita done, does that mean the CI will run again? 😞😨

Yeah 😬 we should probably open a ticket to include changelog changes in that category of docs changes that only trigger the docs jobs, (rather than all 100+ jobs).

@ancalita
Copy link
Member

ancalita commented Apr 5, 2023

@vcidst Thinking again of this poetry lock change, I still think we should add websockets with the constraint in pyproject.toml, reason being that if in the near future the lock file gets refreshed because of some other dependency we need to update on 3.5.x, this change will be lost.

@vcidst
Copy link
Contributor Author

vcidst commented Apr 5, 2023

You're right, I can add websockets as a direct dependency with this constraint. This will be temporary though because,

  • Sanic will fix this soon for sanic==21.12.0
  • And, we'll upgrade to sanic==22.12.0 or sanic==23.3.0

I'll make the changes right away

@ancalita ancalita disabled auto-merge April 5, 2023 09:57
@ancalita ancalita enabled auto-merge (squash) April 5, 2023 09:58
@github-actions
Copy link
Contributor

github-actions bot commented Apr 5, 2023

🚀 A preview of the docs have been deployed at the following URL: https://12238--rasahq-docs-rasa-v2.netlify.app/docs/rasa

@ancalita ancalita merged commit 4284994 into 3.5.x Apr 5, 2023
@ancalita ancalita deleted the ATO-921-for-35x branch April 5, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants