Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ATO 1080] create product documentation for markers #12527
[ATO 1080] create product documentation for markers #12527
Changes from 8 commits
c08b9b1
e0775e5
859d1a8
d2607f4
75fac49
18b0469
03b7250
8bd7dc2
5e73d1a
2569527
662c33a
7e1035a
0c3e781
bd7d6b2
c331aef
88ded25
8385571
b5a0fab
0789173
fb32a4e
23b8b2c
ce70b0d
61f6052
bddcf53
f253589
506c1ff
69c590f
81048b7
f9debbc
bd73bd6
b0523f0
3a056ec
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you stop forwarding real-time markers?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry I didn't understand your question. Did you mean to ask how does one stop uploading the marker-configurations to rasa-pro-services? The marker-configurations are only forwarded to rasa-pro-services (referred as Analytics Data Pipeline in the documentation) when this command is run.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the impression that this command starts "real time processing" of markers and that it kicks off real-time forwarding of markers to the analytics pipeline by Rasa.
I must be confused about what happens when you run this command.
Does the command do a one time upload of markers to the analytics and then exit? Does it run and forward markers until you manually stop the command?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This command uploads the marker-configuration(aka patterns) files and then exits. Rasa Analytics stores these patterns in a database table called
rasa_patterns
. To remove any pattern, you can remove them from the YAML file and runrasa markers upload
again.Rasa Analytics will then process all events from Kafka and extract any markers that it founds in the stream of events. The markers are extracted based on the patterns in
rasa_patterns
table. Extracted markers are stored inrasa_markers
tableThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's a "marker definition"? Above, it says "This command uploads the marker configurations to the data pipeline." and here it's talking about the "marker definitions are uploaded"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree that's a bit confusing. Marker definition or marker configuration refers here to the YAML files that describe the marker in the following manner,
This information is used to identify when these event sequences occur in the conversation. Or, when
marker_cheer_up_success
is extracted from a conversation. To differentiate these, I have referred the YAML files as "marker-configuration" and the markers found in the conversations as "extracted markers".Do you have any suggestions for making this distinction more clear and simplified?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add an example query and graph for markers on the Example queries page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can add an example query and graph to visualise
num_preceeding_user_turns
for a marker that tracks when user has completed the form. It'll visualise the number of turns users took to complete the form and can help give insight if the users are struggling to complete the form. Will something like that be helpful? It's only one of the many use cases of this featureThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A form related example would be really good. When Alana and I recently wrote the blog post on this subject, we really needed a completion rate example. For a given form or story, how many people started the form and how many completed it successfully.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll add this example to this documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rgstephens With a release schedule of next week, we're short on time to add this example at the moment but I've created a ticket at https://rasahq.atlassian.net/browse/ATO-1227 for this and we'll add this example in a micro release