wrap up and tests for flow trigger action #12938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmbo
commented
Oct 24, 2023
| @@ -22,54 +22,81 @@ | |||
| structlogger = structlog.get_logger(__name__) | |||
|
|
|||
|
|
|||
| class FlowTriggerAction(action.Action): | |||
| """Action which implements and executes the form logic.""" | |||
| class ActionTriggerFlow(action.Action): | |||
There was a problem hiding this comment.
renamed to align with other trigger action
twerkmeister
approved these changes
Oct 26, 2023
| assert len(event.value) == 2 | ||
| assert event.value[1]["type"] == UserFlowStackFrame.type() | ||
| assert event.value[1]["flow_id"] == "foo" | ||
| assert event.value[1]["frame_type"] == FlowStackFrameType.INTERRUPT.value |
There was a problem hiding this comment.
please also test that it's a regular frame when there is nothing there yet :)
tmbo
deleted the
ENG-584-wrap-up-flow-trigger-action-refactor-tests-review
branch
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
fixes https://rasahq.atlassian.net/browse/ENG-584