Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify LLMCommandGenerator prompt to include possible categorical slot values - [ENG 607] #12942

Merged
merged 2 commits into from
Oct 27, 2023
Merged

Modify LLMCommandGenerator prompt to include possible categorical slot values - [ENG 607] #12942

merged 2 commits into from
Oct 27, 2023

Conversation

varunshankar
Copy link
Contributor

@varunshankar varunshankar commented Oct 25, 2023 •
edited
Loading

Proposed changes:

  • The LLMCommandGenerator currently includes the allowed values of categorical slots only when an active flow is present. Adding the allowed values to the slots, at the time of defining the flows helps in the LLM mapping the input to one of the defined categorical values.
  • Added e2e tests - https://github.com/RasaHQ/financial-demo-flows-llms/pull/50

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@varunshankar varunshankar requested a review from a team as a code owner October 25, 2023 22:56
@varunshankar varunshankar self-assigned this Oct 25, 2023
djcowley
djcowley approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@djcowley djcowley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@sonarcloud
Copy link

sonarcloud bot commented Oct 27, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug C 4 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 2 Security Hotspots
Code Smell A 54 Code Smells

0.0% 0.0% Coverage
0.8% 0.8% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

tmbo
tmbo approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@varunshankar varunshankar merged commit 864fe08 into dm2 Oct 27, 2023
101 checks passed
@varunshankar varunshankar deleted the ENG-607-categorical-slot-handling branch October 27, 2023 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djcowley djcowley djcowley approved these changes

@tmbo tmbo tmbo approved these changes

@twerkmeister twerkmeister Awaiting requested review from twerkmeister

Assignees

@varunshankar varunshankar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@varunshankar @tmbo @djcowley