Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove scheduled runs of the CI GPU workflows #13012

Merged
merged 2 commits into from
Feb 19, 2024
Merged

Conversation

rasa-jmac
Copy link
Contributor

Proposed changes:

  • Disable the CI workflows that deploy + use GPUs on GCP.
  • Additionally, I've disabled the GCP service accounts that these workflows used.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@rasa-jmac rasa-jmac requested a review from a team as a code owner February 16, 2024 12:06
@rasa-jmac rasa-jmac requested review from miraai, m-vdb, sanchariGr and djcowley and removed request for a team and miraai February 16, 2024 12:06
@m-vdb
Copy link
Collaborator

m-vdb commented Feb 16, 2024

@rasa-jmac why not just remove the workflow files? we can always look at git history if we want to look at example implementation

@rasa-jmac
Copy link
Contributor Author

@m-vdb I can if you'd prefer - just wanted to make minor changes in case it had unintended consequences

@m-vdb
Copy link
Collaborator

m-vdb commented Feb 16, 2024

I think it avoids confusion, IMO -- @djcowley do you agree?

@rasa-jmac
Copy link
Contributor Author

@m-vdb I reckon you're right, I've just removed the files now.

@rasa-jmac rasa-jmac merged commit 914bb98 into main Feb 19, 2024
90 of 91 checks passed
@rasa-jmac rasa-jmac deleted the INFRA-300/remove_k8s_ci branch February 19, 2024 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants