Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete auto main to branch merge workflow #13013

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Delete auto main to branch merge workflow #13013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
555a74c
Delete auto main to branch merge workflow
sanchariGr Feb 19, 2024
6ba1632
Delete auto main to branch merge workflow and remove sonar check from CI
sanchariGr Feb 19, 2024
dd295b3
Update graphviz installer
sanchariGr Feb 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
113 changes: 0 additions & 113 deletions .github/workflows/automatic-release-to-main-merger.yml
View file
Open in desktop

This file was deleted.

14 changes: 0 additions & 14 deletions .github/workflows/continous-integration.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,20 +588,6 @@ jobs:
coverage combine "${final_dir}/"*
coverage xml
- name: Analyse code with SonarCloud
uses: sonarsource/sonarcloud-github-action@5875562561d22a34be0c657405578705a169af6c
Comment on lines -591 to -592
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is SonarCloud removed?

Copy link
Collaborator Author

@sanchariGr sanchariGr Feb 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Explained in the Pr description above. Sonar org was changed to private and we can now only include private repos in it. So oss will not have sonar coverage anymore.

env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}
with:
args: >
-Dsonar.organization=rasahq
-Dsonar.projectKey=RasaHQ_rasa
-Dsonar.sources=.
-Dsonar.python.coverage.reportPaths=${{ github.workspace }}/tests_coverage
-Dsonar.host.url=https://sonarcloud.io
-Dsonar.verbose=true
integration_test:
name: Run Non-Sequential Integration Tests
if: github.ref_type != 'tag'
Expand Down
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@ prepare-tests-windows:
# It will retry the installation 5 times if it fails
# See: https://github.com/actions/virtual-environments/blob/main/images/win/scripts/ImageHelpers/ChocoHelpers.ps1
prepare-tests-windows-gha:
powershell -command "Choco-Install wget graphviz"
powershell -command "Install-ChocoPackage wget graphviz"

test: clean
# OMP_NUM_THREADS can improve overall performance using one thread by process (on tensorflow), avoiding overload
Expand Down
Loading