Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use file utils with proper encoding instead of open #5180

Merged
merged 4 commits into from
Feb 5, 2020
Merged

use file utils with proper encoding instead of open #5180

merged 4 commits into from
Feb 5, 2020

Conversation

tmbo
Copy link
Member

@tmbo tmbo commented Feb 3, 2020

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • reformat files using black (please check Readme for instructions)

@tmbo tmbo requested a review from ricwo February 3, 2020 21:28
ricwo
ricwo approved these changes Feb 4, 2020
View reviewed changes
Copy link
Contributor

@ricwo ricwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great 👍Can you add a misc changelog entry?

@tmbo tmbo changed the title use file utils with proper encoding instead of open. fixes #4495 use file utils with proper encoding instead of open Feb 4, 2020
@tmbo tmbo merged commit cb17e17 into master Feb 5, 2020
@tmbo tmbo deleted the use-file-utils branch February 5, 2020 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricwo ricwo ricwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Refactor tests to use rasa.utils.io functions while loading training and config files
2 participants
@tmbo @ricwo