Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix nlu comparison persist/load nlg responses #5202

Closed
wants to merge 71 commits into from
Closed
Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
71 commits
Select commit Hold shift + click to select a range
c2088e0
how to deploy docs page
indam23 Feb 3, 2020
6697d7b
how to deploy docs page
indam23 Feb 3, 2020
33946ca
Merge branch 'how_to_deploy' of github.com:RasaHQ/rasa into how_to_de…
indam23 Feb 3, 2020
2ffa102
Update docs/user-guide/how-to-deploy.rst
indam23 Feb 3, 2020
197a6f7
Update docs/user-guide/how-to-deploy.rst
indam23 Feb 4, 2020
f98aa95
Update docs/user-guide/how-to-deploy.rst
indam23 Feb 4, 2020
f9fa05e
Update docs/user-guide/how-to-deploy.rst
indam23 Feb 4, 2020
76a75dc
how to deploy doc updates
indam23 Feb 5, 2020
a3af5db
merge with origin
indam23 Feb 5, 2020
7f088b9
Update docs/user-guide/how-to-deploy.rst
indam23 Feb 5, 2020
712d171
make integer primary key compatible with oracle
akelad Feb 7, 2020
deb5218
add docs for oracle tracker store
akelad Feb 7, 2020
96d5218
add to changelog
akelad Feb 7, 2020
a24376a
Add check for text features
tabergma Feb 7, 2020
acdddd4
fix SQL highlighting
akelad Feb 7, 2020
5adbca8
persist nlg responses along with nlu data for nlu pipeline comparison
indam23 Feb 7, 2020
c729a98
changelog for 5201 bugfix
indam23 Feb 7, 2020
2f722fe
review comments
tabergma Feb 7, 2020
a3150dc
reordering
tabergma Feb 7, 2020
b89349a
format fixes
indam23 Feb 7, 2020
cc85153
fix tests
tabergma Feb 7, 2020
d9ccbff
add to pytest of nlu comparison to ensure model files are actually cr…
indam23 Feb 7, 2020
173475a
add data for test
indam23 Feb 7, 2020
7ae4f4f
Merge pull request #5200 from RasaHQ/fix-check-test-features
tabergma Feb 10, 2020
b20dbf2
Apply suggestions from code review
akelad Feb 10, 2020
037cd5b
update changelog entries
akelad Feb 10, 2020
b2c63a8
Merge branch 'oracle-compatibility' of github.com:RasaHQ/rasa into or…
akelad Feb 10, 2020
379e642
move create_sequence def to tracker_store
akelad Feb 10, 2020
06f23c4
Update docs/user-guide/how-to-deploy.rst
akelad Feb 10, 2020
8c176f2
rename running the server to Configuring the HTTP API
indam23 Feb 10, 2020
137807f
Merge pull request #5177 from RasaHQ/how_to_deploy
akelad Feb 10, 2020
d5fecd4
improved utf-8 file loading. #5106
tmbo Feb 4, 2020
a0ac50a
Merge branch '1.7.x' into rename_running_server_rebase
indam23 Feb 10, 2020
63f8a1c
Update how-to-deploy.rst
indam23 Feb 10, 2020
6424b19
Update old-nlu-migration-guide.rst
indam23 Feb 10, 2020
f0b28ea
make data path a constant variable
indam23 Feb 10, 2020
acdb499
Update index.rst
indam23 Feb 10, 2020
c9c7da8
fix cloudpickle version
tabergma Feb 11, 2020
307a3fc
review comments
tabergma Feb 11, 2020
0f0483c
Merge pull request #5183 from RasaHQ/improve-utf8-handling
tmbo Feb 11, 2020
8a9e9db
Merge pull request #5217 from RasaHQ/cloudpickle
tabergma Feb 11, 2020
2d4bf83
prepared release of version 1.7.1
tabergma Feb 11, 2020
22f0a99
Merge pull request #5221 from RasaHQ/prepare-release-1.7.1
tabergma Feb 11, 2020
4b7448a
also check if hostname is set since this otherwise breaks on Python 3…
wochinge Feb 11, 2020
d9b72f0
don't import function directly
wochinge Feb 11, 2020
30c2329
handle in-memory sqlite urls
wochinge Feb 12, 2020
28ec6c5
black formatting
wochinge Feb 12, 2020
0cbc70d
update docstring
akelad Feb 12, 2020
79a5ffd
Merge pull request #5222 from RasaHQ/fix-urlsplit-python3.7.6
wochinge Feb 12, 2020
2e9f490
Merge branch '1.7.x' into oracle-compatibility
akelad Feb 12, 2020
56c5152
fix reference to running rasa with docker
akelad Feb 12, 2020
03e6134
update database compatibility docs
akelad Feb 13, 2020
8647eb7
Merge pull request #5197 from RasaHQ/oracle-compatibility
akelad Feb 13, 2020
73c9235
Merge branch '1.7.x' into rename_running_server_rebase
akelad Feb 13, 2020
8ba2b4f
update changelog
akelad Feb 13, 2020
091bd0c
Merge pull request #5210 from RasaHQ/rename_running_server_rebase
akelad Feb 13, 2020
b85ffc9
prepared release of version 1.7.2
akelad Feb 13, 2020
91d699a
fix oracle changelog entry
akelad Feb 13, 2020
caf96f6
Merge pull request #5237 from RasaHQ/prepare-release-1.7.2
akelad Feb 13, 2020
5309094
fix link to invite users to test
akelad Feb 13, 2020
086c724
Merge pull request #5242 from RasaHQ/fix_docs_link
erohmensing Feb 13, 2020
dfea4aa
pin gym version to avoid segmentation fault
wochinge Feb 17, 2020
02f6d83
remove unused import
wochinge Feb 17, 2020
b7558ad
add changelog
wochinge Feb 17, 2020
3d8fa7f
Merge pull request #5248 from RasaHQ/pin-gym
tmbo Feb 17, 2020
d464ebd
persist nlg responses along with nlu data for nlu pipeline comparison
indam23 Feb 7, 2020
4ca0b5b
changelog for 5201 bugfix
indam23 Feb 7, 2020
4809e85
add to pytest of nlu comparison to ensure model files are actually cr…
indam23 Feb 7, 2020
8288676
add data for test
indam23 Feb 7, 2020
1520976
make data path a constant variable
indam23 Feb 10, 2020
e1cbd8a
Merge branch 'bug_nlu_comparison_nlg_responses' of github.com:RasaHQ/…
indam23 Feb 19, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions changelog/5201.bugfix.rst
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
Fix bug encountering:
``Error: No response phrases found for <out_of_scope/other>.
Check training data files for a possible wrong intent name in NLU/NLG file``
during NLU pipeline comparison with ``ResponseSelector`` and NLG

When NLU training data is split before NLU pipeline comparison,
NLG responses were not also persisted and therefore training for a pipeline including the ``ResponseSelector`` would fail.

NLG responses are now persisted along with NLU data to a ``/train`` directory in the ``run_x/xx%_exclusion`` folder.
1 change: 1 addition & 0 deletions rasa/constants.py
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@

TEST_DATA_FILE = "test.md"
TRAIN_DATA_FILE = "train.md"
NLG_DATA_FILE = "responses.md"
RESULTS_FILE = "results.json"
NUMBER_OF_TRAINING_STORIES_FILE = "num_stories.json"
PERCENTAGE_KEY = "__percentage__"
Expand Down
15 changes: 11 additions & 4 deletions rasa/nlu/test.py
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@

import rasa.utils.io as io_utils

from rasa.constants import TEST_DATA_FILE, TRAIN_DATA_FILE
from rasa.constants import TEST_DATA_FILE, TRAIN_DATA_FILE, NLG_DATA_FILE
from rasa.nlu.constants import (
DEFAULT_OPEN_UTTERANCE_TYPE,
RESPONSE_SELECTOR_PROPERTY_NAME,
Expand Down Expand Up @@ -1442,9 +1442,16 @@ def compare_nlu(
training_examples_per_run.append(len(train.training_examples))

model_output_path = os.path.join(run_path, percent_string)
train_split_path = os.path.join(model_output_path, TRAIN_DATA_FILE)
io_utils.create_path(train_split_path)
write_to_file(train_split_path, train.nlu_as_markdown())
train_split_path = os.path.join(model_output_path, "train")
train_nlu_split_path = os.path.join(
model_output_path, "train", TRAIN_DATA_FILE
)
train_nlg_split_path = os.path.join(
model_output_path, "train", NLG_DATA_FILE
)
io_utils.create_path(train_nlu_split_path)
write_to_file(train_nlu_split_path, train.nlu_as_markdown())
write_to_file(train_nlg_split_path, train.nlg_as_markdown())

for nlu_config, model_name in zip(configs, model_names):
logger.info(
Expand Down