Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix urlsplit python3.7.6 #5222

Merged
merged 4 commits into from
Feb 12, 2020
Merged

Fix urlsplit python3.7.6 #5222

merged 4 commits into from
Feb 12, 2020

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented Feb 11, 2020 •
edited by chkoss
Loading

Proposed changes:

  • fix behavior of Python 3.7.6 where urlsplit("localhost:1234") returns ParseResult(scheme='localhost', netloc='', path='1234', params='', query='', fragment='')

Status (please check what you already did):

  • added some tests for the functionality (already covered, failed on @ChristinaKoss machine)
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@wochinge wochinge changed the base branch from master to 1.7.x February 11, 2020 13:50
@wochinge
Copy link
Contributor Author

do we need a changelog for that?

chkoss
chkoss reviewed Feb 11, 2020
View reviewed changes
Copy link
Contributor

@chkoss chkoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just tried pytest tests/core/test_tracker_stores.py::test_get_db_url_with_port_in_host (the test that previously failed on my machine). It passes now 👍

federicotdn
federicotdn approved these changes Feb 11, 2020
View reviewed changes
Copy link
Contributor

@federicotdn federicotdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If there wasn't an issue created for it I would say it's not necessary 👍

@wochinge wochinge requested a review from federicotdn February 12, 2020 10:57
federicotdn
federicotdn approved these changes Feb 12, 2020
View reviewed changes
Copy link
Contributor

@federicotdn federicotdn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@wochinge wochinge merged commit 79a5ffd into 1.7.x Feb 12, 2020
@wochinge wochinge deleted the fix-urlsplit-python3.7.6 branch February 12, 2020 13:42
@hsm207 hsm207 mentioned this pull request Jun 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chkoss chkoss chkoss left review comments

@federicotdn federicotdn federicotdn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wochinge @federicotdn @chkoss