Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update docker action server docs #5302

Merged
merged 31 commits into from
Mar 24, 2020
Merged

update docker action server docs #5302

merged 31 commits into from
Mar 24, 2020

Conversation

erohmensing
Copy link
Contributor

@erohmensing erohmensing commented Feb 24, 2020

Proposed changes:

TO DO: Create a redirect for https://rasa.com/docs/rasa/user-guide/running-rasa-with-docker/#adding-custom-actions

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@erohmensing erohmensing changed the base branch from docker-permission to 1.7.x February 25, 2020 09:52
@TyDunn
Copy link
Contributor

TyDunn commented Feb 25, 2020

I read through both PRs. They both seem pretty good, but I will walk through the steps myself tomorrow

@akelad
Copy link
Contributor

akelad commented Feb 25, 2020

image
are we aware this headline is tinier than the actual font?

@erohmensing
Copy link
Contributor Author

erohmensing commented Feb 25, 2020

@akelad Yeah, it has to do with there being way too much information on this page. IMO that's another reason to take out the "building a bot in docker" info and move it away from the "deploying your assistant" page

Also something that we should make sure in the future doesn't happen in our sphinx theme (there should be a font size mininum for headers that is bigger than the regular text)

@erohmensing erohmensing changed the base branch from 1.7.x to 1.8.x March 2, 2020 14:27
@akelad
Copy link
Contributor

akelad commented Mar 4, 2020

looking at this now, but gettign a bunch of warnings :D

/Users/akela/Documents/rasa-new/docs/user-guide/docker/building-in-docker.rst:121: WARNING: duplicate label model_training_docker, other instance in /Users/akela/Documents/rasa-new/docs/user-guide/how-to-deploy.rst
/Users/akela/Documents/rasa-new/docs/user-guide/docker/deploying-in-docker.rst:14: WARNING: duplicate label running-the-rasa-server, other instance in /Users/akela/Documents/rasa-new/docs/user-guide/how-to-deploy.rst
/Users/akela/Documents/rasa-new/docs/user-guide/docker/deploying-in-docker.rst:123: WARNING: duplicate label building-an-action-server-image, other instance in /Users/akela/Documents/rasa-new/docs/user-guide/how-to-deploy.rst

@erohmensing
Copy link
Contributor Author

@akelad Haha sorry, it's in a middle state right now 😄TBH what would be best is a review of the updated docker action server before the content moved around, and then answering my 2 questions for you

the rest can still use a little restructing work, which is what i'm workin on 😋

@akelad
Copy link
Contributor

akelad commented Mar 4, 2020

i think generally the main landing page looks good and concise now. I'm not too sure about building with docker still either... But yeah i'll look at the custom action stuff specifically.

Copy link
Contributor

@akelad akelad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good generally but few things to change

docs/api/tracker-stores.rst Outdated Show resolved Hide resolved
docs/user-guide/docker/building-in-docker.rst Outdated Show resolved Hide resolved
docs/user-guide/docker/building-in-docker.rst Outdated Show resolved Hide resolved
docs/user-guide/docker/building-in-docker.rst Outdated Show resolved Hide resolved
docs/user-guide/docker/building-in-docker.rst Outdated Show resolved Hide resolved
docs/user-guide/docker/building-in-docker.rst Outdated Show resolved Hide resolved
docs/user-guide/docker/deploying-in-docker.rst Outdated Show resolved Hide resolved
@erohmensing
Copy link
Contributor Author

Alright, let's try this again

@erohmensing erohmensing requested a review from akelad March 17, 2020 16:17
@erohmensing erohmensing requested a review from TyDunn March 17, 2020 16:17
Copy link
Contributor

@akelad akelad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few small things, few things i'm unsure about :D

docs/api/tracker-stores.rst Show resolved Hide resolved
docs/api/tracker-stores.rst Outdated Show resolved Hide resolved
docs/api/tracker-stores.rst Outdated Show resolved Hide resolved
docs/api/tracker-stores.rst Outdated Show resolved Hide resolved
docs/user-guide/docker/building-in-docker.rst Show resolved Hide resolved
docs/user-guide/docker/deploying-in-docker-compose.rst Outdated Show resolved Hide resolved
docs/user-guide/docker/deploying-in-docker-compose.rst Outdated Show resolved Hide resolved
docs/user-guide/how-to-deploy.rst Outdated Show resolved Hide resolved
docs/user-guide/how-to-deploy.rst Outdated Show resolved Hide resolved
docs/user-guide/how-to-deploy.rst Show resolved Hide resolved
@erohmensing erohmensing added this to the Rasa 1.9 milestone Mar 23, 2020
@erohmensing erohmensing requested a review from akelad March 23, 2020 22:04
Copy link
Contributor

@akelad akelad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work! few more comments, you can decide which ones to address now and which ones to move to an issue for future fixing :D

docs/api/tracker-stores.rst Outdated Show resolved Hide resolved
docs/api/tracker-stores.rst Outdated Show resolved Hide resolved
docs/user-guide/docker/building-in-docker.rst Outdated Show resolved Hide resolved
docs/user-guide/docker/building-in-docker.rst Outdated Show resolved Hide resolved
docs/user-guide/docker/building-in-docker.rst Outdated Show resolved Hide resolved
docs/user-guide/docker/building-in-docker.rst Show resolved Hide resolved
docs/user-guide/docker/building-in-docker.rst Show resolved Hide resolved
@erohmensing erohmensing merged commit e5d8acc into 1.8.x Mar 24, 2020
@erohmensing erohmensing deleted the docker-action-server branch March 24, 2020 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants