Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove prompt-toolkit from Rasa dependencies #5556

Merged
merged 3 commits into from
Apr 2, 2020
Merged

Remove prompt-toolkit from Rasa dependencies #5556

merged 3 commits into from
Apr 2, 2020

Conversation

alwx
Copy link
Contributor

@alwx alwx commented Apr 1, 2020 •
edited
Loading

Proposed changes:

  • remove prompt-toolkit from Rasa dependencies because it's not a direct dependency

Status (please check what you already did):

  • updated the changelog (please check changelog for instructions)

@alwx alwx requested a review from ricwo April 1, 2020 14:36
ricwo
ricwo approved these changes Apr 1, 2020
View reviewed changes
Copy link
Contributor

@ricwo ricwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@alwx alwx merged commit a46dca3 into master Apr 2, 2020
@wochinge
Copy link
Contributor

wochinge commented Apr 6, 2020

@alwx Can we also backport and release this as a patch?

@tmbo tmbo deleted the prompt-toolkit-removal branch May 1, 2020 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricwo ricwo ricwo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alwx @wochinge @ricwo