Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved filtering for NLU training data examples #5614

Merged
merged 12 commits into from
Apr 15, 2020
Merged

Improved filtering for NLU training data examples #5614

merged 12 commits into from
Apr 15, 2020

Conversation

alwx
Copy link
Contributor

@alwx alwx commented Apr 10, 2020 •
edited
Loading

Proposed changes:
This PR replaces the existing filter_by_intent function with filter_training_examples that accepts a filtering function and allows to do any kind of filtering based on this function. It allows, for example, to filter out retrieval intents which is required for Rasa X.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@alwx alwx requested a review from dakshvar22 April 10, 2020 14:07
@alwx alwx requested a review from ricwo April 14, 2020 10:17
dakshvar22
dakshvar22 approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@dakshvar22 dakshvar22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one optional comment.

rasa/nlu/training_data/training_data.py Show resolved Hide resolved
dakshvar22
dakshvar22 requested changes Apr 14, 2020
View reviewed changes
rasa/nlu/training_data/training_data.py Outdated Show resolved Hide resolved
rasa/nlu/training_data/training_data.py Outdated Show resolved Hide resolved
rasa/nlu/training_data/training_data.py Outdated Show resolved Hide resolved
@alwx alwx requested a review from dakshvar22 April 14, 2020 14:49
dakshvar22
dakshvar22 approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@dakshvar22 dakshvar22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing the comments 🚀

ricwo
ricwo approved these changes Apr 14, 2020
View reviewed changes
Copy link
Contributor

@ricwo ricwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

changelog/5614.misc.rst Outdated Show resolved Hide resolved
rasa/nlu/training_data/training_data.py Outdated Show resolved Hide resolved
rasa/nlu/training_data/training_data.py Outdated Show resolved Hide resolved
rasa/nlu/selectors/response_selector.py Outdated Show resolved Hide resolved
rasa/nlu/training_data/training_data.py Outdated Show resolved Hide resolved
rasa/nlu/training_data/training_data.py Outdated Show resolved Hide resolved
rasa/nlu/training_data/training_data.py Outdated Show resolved Hide resolved
rasa/nlu/training_data/training_data.py Outdated Show resolved Hide resolved
@alwx alwx merged commit d55e868 into master Apr 15, 2020
@tmbo tmbo deleted the filter-operation branch October 7, 2020 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricwo ricwo ricwo approved these changes

@dakshvar22 dakshvar22 dakshvar22 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alwx @dakshvar22 @ricwo