-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RulePolicy: Abstract loop interface + TwoStageFallbackPolicy #5933
Conversation
Quick note: the sense of the interface definition will probably be tested (and potentially changed) when doing the |
8e092a6
to
84e0b05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overral looks good, there are places to think about, but if it works I think we can merge it for now
It has to be hardcoded since the TwoStageFallbackPolicy relies on it's name, similar to the out of scope intent name
Proposed changes:
Loop
interface which can be implemented for conversation parts which should be handled outside of MLFormAction
to loop interfaceFallbackClassifier
since theTwoStageFallbackClassifier
relies on the intent nameStatus (please check what you already did):
black
(please check Readme for instructions)