Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RulePolicy: Abstract loop interface + TwoStageFallbackPolicy #5933

Merged
merged 6 commits into from
Jun 13, 2020

Conversation

wochinge
Copy link
Contributor

@wochinge wochinge commented Jun 2, 2020

Proposed changes:

  • fix Implement TwoStageFallbackPolicy for the RulePolicy #5915
  • create abstract Loop interface which can be implemented for conversation parts which should be handled outside of ML
  • adapt FormAction to loop interface
  • implement TwoStageFallbackPolicy as action
  • hardcode intent name of FallbackClassifier since the TwoStageFallbackClassifier relies on the intent name

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@wochinge wochinge marked this pull request as draft June 2, 2020 20:58
rasa/core/actions/loop.py Outdated Show resolved Hide resolved
@wochinge wochinge changed the title Abstract loop RulePolicy: Abstract loop interface + TwoStageFallbackPolicy Jun 2, 2020
rasa/core/actions/forms.py Outdated Show resolved Hide resolved
rasa/core/actions/loop.py Outdated Show resolved Hide resolved
rasa/core/actions/loop.py Outdated Show resolved Hide resolved
@wochinge
Copy link
Contributor Author

wochinge commented Jun 3, 2020

Quick note: the sense of the interface definition will probably be tested (and potentially changed) when doing the TwoStageFallback implementation since I'll then see whether the abstraction was correct.

@wochinge wochinge force-pushed the abstract-loop branch 2 times, most recently from 8e092a6 to 84e0b05 Compare June 8, 2020 14:13
@wochinge wochinge requested a review from Ghostvv June 8, 2020 14:17
Copy link
Contributor

@Ghostvv Ghostvv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overral looks good, there are places to think about, but if it works I think we can merge it for now

rasa/core/actions/forms.py Outdated Show resolved Hide resolved
rasa/core/actions/forms.py Outdated Show resolved Hide resolved
rasa/core/actions/forms.py Show resolved Hide resolved
rasa/core/actions/loops.py Outdated Show resolved Hide resolved
rasa/core/actions/two_stage_fallback.py Show resolved Hide resolved
rasa/core/actions/two_stage_fallback.py Show resolved Hide resolved
tests/core/actions/test_forms.py Show resolved Hide resolved
@wochinge wochinge marked this pull request as ready for review June 11, 2020 07:49
@wochinge wochinge merged commit 440ede7 into rules Jun 13, 2020
@wochinge wochinge deleted the abstract-loop branch June 13, 2020 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants