New Form featurization #6029
Merged
New Form featurization #6029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wochinge
commented
Jun 16, 2020
wochinge
commented
Jun 16, 2020
| @@ -398,7 +401,9 @@ def generate_all_prior_trackers( | |||
| def applied_events(self) -> List[Event]: | |||
There was a problem hiding this comment.
@Ghostvv Could you have a short look please? I also added some tests to test_trackers where you can see how the applied_events() vs the raw tracker
Ghostvv
suggested changes
Jun 17, 2020
wochinge
force-pushed
the
form-featurization
branch
from
9d760f5
to
b75b00d
Compare
Ghostvv
reviewed
Jun 22, 2020
wochinge
force-pushed
the
form-featurization
branch
from
b75b00d
to
26fee64
Compare
Ghostvv
approved these changes
Jun 23, 2020
wochinge
force-pushed
the
form-featurization
branch
2 times, most recently
from
73df3b1
to
aa2ac65
Compare
The `FormPolicy` will be removed in favor of the `RulePolicy` so no need to fix / adapt the tests here.
wochinge
force-pushed
the
form-featurization
branch
from
1e7175f
to
1f2efe4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Status (please check what you already did):
black(please check Readme for instructions)