Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RulePolicy: scope dispatches per form #6030

Merged
merged 2 commits into from
Jun 24, 2020
Merged

Conversation

alwx
Copy link
Contributor

@alwx alwx commented Jun 16, 2020

Proposed changes:

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@alwx alwx marked this pull request as ready for review June 17, 2020 07:26
@alwx alwx requested a review from wochinge June 17, 2020 07:28
@alwx
Copy link
Contributor Author

alwx commented Jun 17, 2020

It seems simple, so I am not entirely sure if I took everything into consideration. @wochinge could you please check and let me know?

Copy link
Contributor

@wochinge wochinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 Can you please add a short test?

@alwx alwx merged commit bed6aeb into rules Jun 24, 2020
@alwx alwx deleted the rules-scope-dispatched-per-form branch June 24, 2020 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants