Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Webex Channel Fix: personId -> roomId #6078

Merged
merged 4 commits into from
Jul 1, 2020
Merged

Webex Channel Fix: personId -> roomId #6078

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8d3ebe9
Webex Channel Fix: personId -> roomId
isaac-philip Jun 26, 2020
4a7993b
Changelog entry added!
isaac-philip Jun 30, 2020
2719d99
Update changelog/6078.bugfix.rst
wochinge Jul 1, 2020
41ab4de
Update changelog/6078.bugfix.rst
wochinge Jul 1, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog/6078.bugfix.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
bot will respond through `webex` channel to any user(room) communicating to it. Earlier bot responds only to fixed `roomId` set in credentials.yml config file correctly.
wochinge marked this conversation as resolved.
Show resolved Hide resolved
4 changes: 2 additions & 2 deletions rasa/core/channels/webexteams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ async def send_image_url(
async def send_custom_json(
self, recipient_id: Text, json_message: Dict[Text, Any], **kwargs: Any
) -> None:
json_message.setdefault("roomID", recipient_id)
json_message.setdefault("roomId", recipient_id)
return self.api.messages.create(**json_message)


Expand Down Expand Up @@ -128,7 +128,7 @@ async def webhook(request: Request) -> HTTPResponse:
else:
metadata = self.get_metadata(request)
await self.process_message(
on_new_message, message.text, message.personId, metadata
on_new_message, message.text, message.roomId, metadata
)
return response.text("")

Expand Down