-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add possibility to split the domain into separate files #6132
Conversation
63dc6ad
to
d50d039
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works nicely! Some observations:
- We should update
default_arguments.add_domain_param
as well. Maybe mention there that the value can be a single YAML file, or a directory containing YAML files. - I tried placing three YAML files inside
domains/
and then trained my model. However I got this warning below:
FutureWarning: No tracker session configuration was found in the loaded domain. Domains without a session config will automatically receive a session expiration time of 60 minutes in Rasa version 2.0 if not configured otherwise.
docs=DOCS_URL_DOMAINS + "#session-configuration",
I think this is happening because we're calling Domain.from_dict
for each file, so if one of them doesn't have the session_config
key, the warning will be shown.
I removed the warning and set the default session expiration time to 60 minutes as of now. |
cb59637
to
0b7b3d7
Compare
@federicotdn update: used |
- Add possibility to split the domain into separate files
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 👍
Co-authored-by: Federico Tedin <federicotdn@users.noreply.github.com>
Closes #5984
Proposed changes:
domain
file now doesn't have to be calleddomain.yaml
Status (please check what you already did):
black
(please check Readme for instructions)