Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move option 'case_sensitive' from tokenizers to featurizers #6147

Merged
merged 11 commits into from
Jul 8, 2020

Conversation

tabergma
Copy link
Contributor

@tabergma tabergma commented Jul 6, 2020

Proposed changes:

  • Remove the option from the WhitespaceTokenizer and ConveRTTokenizer.
  • Add option case_sensitive to the RegexFeaturizer.

closes #5759

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@tabergma tabergma requested a review from Ghostvv July 6, 2020 14:35
@rasabot
Copy link
Collaborator

rasabot commented Jul 7, 2020

Could not update branch. Most likely this is due to a merge conflict. Please update the branch manually and fix any issues.

@tabergma tabergma merged commit 3918d9a into master Jul 8, 2020
@tabergma tabergma deleted the case-sensitive branch July 8, 2020 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option case_sensitive to featurizers
5 participants