-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add EntityExtractor as a requirement for EntitySynonymMapper #6236
Add EntityExtractor as a requirement for EntitySynonymMapper #6236
Conversation
Thanks for submitting a pull request 🚀 @akelad will take a look at it as soon as possible ✨ |
@tabergma do you know why that wasn't there in the first place? |
@akelad No idea. We changed the way how to define those required components a couple of month ago. It might be that is was not possible beforehand and we forgot to add it once we changed. But this is definitely a good requirement that we should add. |
agreed, was just checking whether there was a reason we omitted it 👌 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the quick fix @AMR-KELEG! looks good + also works as intended.
Could you add a changelog entry about this bug fix as well please?
Thanks @akelad for verifying that the change works. On the other hand, Should also the doc rst file be modified? |
good find, yes that should also be changed there! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot for this great contribution!!
Closes #6198
Proposed changes:
EntityExtractor
as a requirement forEntitySynonymMapper
in a pipelineStatus (please check what you already did):
black
(please check Readme for instructions)Comment:
I failed to test the PR locally (I have missed up with my clone and I haven't been able to build Rasa from source yet).
I would really appreciate if you can test the edit.
The change is intuitive yet it needs to be tested.