-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check if ActionExecutionRejected
should be thrown after custom action for slot validations was called
#7035
Conversation
…on for slot validations was called
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please update the docs as part of this PR, otherwise looks good to me 🚀
@ArjaanBuijk Could you please check the documentation? |
@tczekajlo The security check for the secrets is currently failing. it's not required but I think we need to exclude |
@melindaloubser1 Requested review from you since @ArjaanBuijk doesn't seems to be busy |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some small phrasing changes directly since it won't allow me to request changes on deleted lines
Thank you so much for this blazing fast review and changes @melindaloubser1 🙌 |
@Ghostvv I'm gonna dismiss your |
docs are there and requested changes were worked in
Proposed changes:
ActionExecutionRejected
after form validation #6977ActionExecutionRejection
error after custom action for slot validations / extractions was called. This doesn't reject forms before users could intervene.ActionExecutionRejected
eventInvalidDomain
instead ofValueError
for invalid slot mappings to avoid unnecessary Sentry errorsActionExecutionRejected
event and still apply other events (e.g. slots)Status (please check what you already did):
black
(please check Readme for instructions)