Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PikaEventBroker to reconnect automatically and handle errors better #7100

Closed
wants to merge 6 commits into from
Closed

Update PikaEventBroker to reconnect automatically and handle errors better #7100

wants to merge 6 commits into from

Conversation

alwx
Copy link
Contributor

@alwx alwx commented Oct 24, 2020 •
edited
Loading

Proposed changes:

  • removes multiprocessing from PikaEventBroker
  • updates functions to handle connection better — automatically reconnect if the connection get closed + proper detection of active connection

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@alwx alwx changed the title Update PikaEventBroker to reconnect automatically and handle errors better. Update PikaEventBroker to reconnect automatically and handle errors better Oct 24, 2020
@indam23 indam23 mentioned this pull request Oct 27, 2020
Closed
4 tasks
@alwx alwx requested a review from ricwo October 27, 2020 12:46
@indam23 indam23 mentioned this pull request Oct 27, 2020
Closed
@alwx alwx closed this Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ricwo ricwo Awaiting requested review from ricwo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@alwx