Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

download mitie from github instead of s3 #7434

Merged
merged 1 commit into from
Dec 2, 2020
Merged

download mitie from github instead of s3 #7434

merged 1 commit into from
Dec 2, 2020

Conversation

tmbo
Copy link
Member

@tmbo tmbo commented Dec 2, 2020

Proposed changes:

  • download mitie from github instead of s3

@tmbo tmbo requested a review from tczekajlo December 2, 2020 09:56
@tmbo
Copy link
Member Author

tmbo commented Dec 2, 2020

@tczekajlo found another location where we are using the download from S3 😅 I've used the same command that you added to the docker file to replace S3

tczekajlo
tczekajlo approved these changes Dec 2, 2020
View reviewed changes
Copy link
Contributor

@tczekajlo tczekajlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@tmbo tmbo merged commit d57a36a into master Dec 2, 2020
@tmbo tmbo deleted the mitie-download branch December 2, 2020 10:44
eanile added a commit to UTkzhang/rasa that referenced this pull request Dec 2, 2020
@eanile @indam23
@alwx @rasabot @erohmensing @m-vdb @wochinge @ducminh-phan @federicotdn @hotzenklotz @tmbo @Henrike100 @mbslet
Merge original repo into fork (#1)
961a8fd 
* backport fix

* backport pika fix

* pika fix backport

* fix tests

* test fixes

* remove logger statement

* Updated version of PikaMessageProcessor from the source branch

* Small bugfix

* changelog

* prepared release of version 1.10.16

* Update CHANGELOG.rst

Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>

* add robots.txt and redirection headers

* bump rasabaster version

* Fix Pika multiprocessing for 1.10.x

* Reformatting

* Changelog entry

* Updated tests

* is_ready method is back

* uninstall cached pydocstyle

* also uninstall pydocstyle

* uninstall in poetry env

* Removing f-string

* NoReturn -> None

* prepared release of version 1.10.17

* Fix incorrect attribute for key prefix in RedisTrackerStore

Fix RasaHQ#7306

* Add changelog entry

* Remove the set-env command - 1.10.x (RasaHQ#7367)

* Fix DynamoDB TrackerStore (RasaHQ#7340)

* attempting to fix dynamo

* fixed

* fixed import

* applied some more fixes

* added deprecation warning for DynamoDB tracker store attribute

* added changelog description for PR 7340

* fix formatting

Co-authored-by: Tom Bocklisch <tom@rasa.com>

* prepared release of version 1.10.18 (RasaHQ#7381)

* Update docstrings

* Update CHANGELOG.mdx

* line length fix

* Add print to confirm that the failed_test_stories.yml has been saved (RasaHQ#6793)

* Add print to confirm that the failed_test_stories.yml has been saved (RasaHQ#3998)

Co-authored-by: Henrike100 <henrikem100@gmail.com>

* Change the way to show the file name

* files formatted with black

* add changelog

* Update test core

* Formatted with black

* Update print

Co-authored-by: mbslet <lmbs.geo@gmail.com>

* Amend response schema to support missing top-level keys (RasaHQ#7232)

* amend response schema to support missing top level keys

* changelog entry

* download mitie from github instead of s3 (RasaHQ#7434)

Co-authored-by: melindaloubser1 <melinda.loubser@gmail.com>
Co-authored-by: alwx <alwxndr@gmail.com>
Co-authored-by: Roberto <43567378+rasabot@users.noreply.github.com>
Co-authored-by: Melinda Loubser <32034278+melindaloubser1@users.noreply.github.com>
Co-authored-by: Ella Rohm-Ensing <erohmensing@gmail.com>
Co-authored-by: m-vdb <m.verger@rasa.com>
Co-authored-by: Tobias Wochinger <t.wochinger@rasa.com>
Co-authored-by: Duc-Minh Phan <alephvn@gmail.com>
Co-authored-by: Federico Tedin <federicotdn@users.noreply.github.com>
Co-authored-by: Tomasz Czekajlo <t.czekajlo@rasa.com>
Co-authored-by: Tom Herold <tom.herold@scalableminds.com>
Co-authored-by: Tom Bocklisch <tom@rasa.com>
Co-authored-by: Henrique Martins <henrikem100@gmail.com>
Co-authored-by: mbslet <lmbs.geo@gmail.com>
Co-authored-by: pheel <philippe@mrbot.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tczekajlo tczekajlo tczekajlo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmbo @tczekajlo