correctly replace database name in query #7585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wochinge
force-pushed
the
fix-login-db
branch
from
9cf54a3 to
b5c9d7b
Compare
wochinge
commented
Dec 17, 2020
| from sqlalchemy import create_engine | ||
|
|
||
| if not self.engine.dialect.name == "postgresql": |
There was a problem hiding this comment.
we could also use https://sqlalchemy-utils.readthedocs.io/en/latest/_modules/sqlalchemy_utils/functions/database.html#create_database but that only supports mysql in addition which doesn't seem worth to include it as extra library (login_db doesn't make sense for sqlite)
degiz
approved these changes
Dec 17, 2020
rasa/core/tracker_store.py
Outdated
| from sqlalchemy import create_engine | ||
|
|
||
| if not self.engine.dialect.name == "postgresql": | ||
| rasa.shared.utils.io.raise_warning( | ||
| f"The parameter 'login_db' can only be used with a postgres database.", |
There was a problem hiding this comment.
Seems a bit a wrong place to warn about login_db, since it was passed as login_db in the constructor of SQLTrackerStore.
There was a problem hiding this comment.
It's called from the constructor, no? And we can only safely determine the dialect once we're connected 🤷🏻
wochinge
force-pushed
the
fix-login-db
branch
from
b5c9d7b to
f15a1a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
sqlalchemy.textconstructStatus (please check what you already did):
black(please check Readme for instructions)