Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prepare-transformers target to Makefile #7768

Merged
merged 3 commits into from
Jan 22, 2021
Merged

Add prepare-transformers target to Makefile #7768

merged 3 commits into from
Jan 22, 2021

Conversation

koernerfelicia
Copy link
Contributor

@koernerfelicia koernerfelicia commented Jan 21, 2021

This target downloads the models needed for testing LanguageModelFeaturizer and stores them in the cache.

Status (please check what you already did):

  • reformat files using black (please check Readme for instructions)

…and cache filenames for HF transformers models
@koernerfelicia
Copy link
Contributor Author

Hi @tczekajlo, let me know what you think of this! I'm not so sure how best to test this out on Windows or Linux (guessing Linux should be fine). How would you do this, do you have a VM?

@tczekajlo
Copy link
Contributor

Hi @tczekajlo, let me know what you think of this! I'm not so sure how best to test this out on Windows or Linux (guessing Linux should be fine). How would you do this, do you have a VM?

LGTM 🎖️ It's already been tested :D the prepare-tests-files is executed during the Install dependencies on Linux and Windows (e.g. https://github.com/RasaHQ/rasa/pull/7768/checks?check_run_id=1743397790), everything looks good.

Copy link
Contributor

@tczekajlo tczekajlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍏

Base automatically changed from master to main January 22, 2021 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants