Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix non expressive variable name on interactive.py #8464

Merged
merged 5 commits into from
Apr 14, 2021

Conversation

rafaelteodosio
Copy link
Contributor

@rafaelteodosio rafaelteodosio commented Apr 14, 2021

Proposed changes:

  • Change variable named i to interactive_story_counter
  • Resolve: #8453
    Status (please check what you already did):
  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@sara-tagger sara-tagger requested a review from samsucik April 14, 2021 06:00
@sara-tagger
Copy link
Collaborator

Thanks for submitting a pull request 🚀 @samsucik will take a look at it as soon as possible ✨

@samsucik samsucik changed the base branch from main to 2.5.x April 14, 2021 07:34
@samsucik samsucik changed the base branch from 2.5.x to main April 14, 2021 07:34
Copy link
Contributor

@samsucik samsucik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @rafaelteodosio! Before we merge this into main, could you remove the changelog entry? The changelog is meant for bigger changes, especially ones that affect users 🙂

@rafaelteodosio
Copy link
Contributor Author

Thanks @rafaelteodosio! Before we merge this into main, could you remove the changelog entry? The changelog is meant for bigger changes, especially ones that affect users 🙂

Ok @samsucik I made the requested change. Thanks.

Copy link
Contributor

@samsucik samsucik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the improvement @rafaelteodosio!

@samsucik samsucik enabled auto-merge (squash) April 14, 2021 11:11
@samsucik samsucik merged commit 99dd20e into RasaHQ:main Apr 14, 2021
@ErickGiffoni ErickGiffoni deleted the 8453-non-expressive-variable-name branch August 5, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non expressive variable name on interactive.py
4 participants