Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change non expressive variable name on shared files #8523

Conversation

rafaelteodosio
Copy link
Contributor

Proposed changes:

  • Change non expressive variables names on the files .../shared/core/training_data/visualization.py , .../shared/core/slots.py, .../shared/nlu/training_data/message.py.

  • Resolve: #8520

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • updated the changelog (please check changelog for instructions)
  • reformat files using black (please check Readme for instructions)

@sara-tagger sara-tagger requested a review from dakshvar22 April 22, 2021 06:00
@sara-tagger
Copy link
Collaborator

Thanks for submitting a pull request 🚀 @dakshvar22 will take a look at it as soon as possible ✨

@dakshvar22
Copy link
Contributor

Hi @rafaelteodosio , sorry for the delay. Are you still interested in taking this up? If yes, could you please merge the latest main branch into your branch so that we can start the review? 🙏

@ErickGiffoni ErickGiffoni deleted the 8520-non-expressive-variable-name-on-shared-files branch August 5, 2021 19:42
@stale
Copy link

stale bot commented Apr 16, 2022

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 16, 2022
@ancalita
Copy link
Member

@rafaelteodosio I can see that the development branch was deleted, as a result i will close this PR.
If you wish to continue work on this issue, please open a new PR.

@ancalita ancalita closed this May 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non expressive variable name on .../shared/ files
5 participants