Filter out pre-trained entities before CRF entity training #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ricwo
changed the title
tmbo
requested changes
Mar 13, 2018
rasa_nlu/extractors/__init__.py
Outdated
| extractor = ent.get("extractor") | ||
| if not extractor or extractor == self.name: | ||
| entities.append(ent) | ||
| message.set("entities", entities) |
There was a problem hiding this comment.
I don't think this will work: This will remove all entities from the message that do not belong to the crf extractor, which is fine. The issue is, that this is modifying the message object directly, which will lead to the entities being removed for every component that comes after the crf component. So if there is any other component that needs some entity annotations after the crf, the entities will be missing.
tmbo
approved these changes
Mar 13, 2018
tmbo
approved these changes
Mar 13, 2018
rasa_nlu/extractors/__init__.py
Outdated
| @@ -25,3 +26,20 @@ def add_processor_name(self, entity): | |||
| else: | |||
| entity["processors"] = [self.name] | |||
| return entity | |||
|
|
|||
| def filter_trainable_entities(self, entity_examples): | |||
|
Nice work in implementing that filtering, thanks Rick 👍 |
taytzehao
pushed a commit
to taytzehao/rasa
that referenced
this pull request
Jul 14, 2023
We should reuse an existing context logger if in test context. This will allow test to setup act with a null logger to assert log messages. Co-authored-by: Markus Wolf <markus.wolf@new-work.se> Co-authored-by: Markus Wolf <markus.wolf@new-work.se>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes:
Extractorobjects have the option to filter out pretrained entity examplesCRFEntityExtractorStatus (please check what you already did):