Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change function order #1162

Closed
wants to merge 3 commits into from

Conversation

p0lycarpio
Copy link
Contributor

Related to #1104 (comment).

Indeed @billz , the order of the functions produces these errors.
Restoring original order in this PR.

@p0lycarpio p0lycarpio closed this Apr 25, 2022
@p0lycarpio
Copy link
Contributor Author

Restoring the function to its original order no longer saves the raspap.auth file during an upgrade.
It is necessary to investigate

@p0lycarpio p0lycarpio reopened this Apr 25, 2022
@p0lycarpio
Copy link
Contributor Author

p0lycarpio commented Apr 25, 2022

1f9638c Reversal of priority of functions in the event of an upgrade.

Explanations:
In the event of an upgrade, the backup of the raspap.auth file must be done in priority with _check_for_old_configs , before launching the _check_for_old_configs function which moves the raspap folder (and raspap.auth) to make a backup.

There may be another way to do this thing but it works for me. Please confirm it to me

@billz
Copy link
Member

billz commented May 30, 2022

To keep things neater, I'd opt for a solution that doesn't use conditionals in the main _install_raspap() function block.

@billz
Copy link
Member

billz commented Jun 24, 2022

Fixed with 9d5088a. @p0lycarpio thanks

@billz billz closed this Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants