Add ability to create assets of other types with the GUI #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cfox
reviewed
Aug 22, 2018
| @@ -27,6 +27,13 @@ enum AssetType | |||
| REISSUE | |||
| }; | |||
|
|
|||
| enum IssueAssetType | |||
There was a problem hiding this comment.
Could these be moved somewhere into qt codebase since they only seem to apply there?
| GetAllOwnedAssets(model->getWallet(), names); | ||
| for (auto item : names) { | ||
| std::string name = QString::fromStdString(item).split("!").first().toStdString(); | ||
| if (name.size() != 30) |
There was a problem hiding this comment.
What is this check for? I think we could have a 30-char asset name (plus !)..
There was a problem hiding this comment.
Yeah. So, I am splitting the ! off of these assets names. Then after that if they are < 30 characters. They won't show up because the asset name is already at the limit
src/qt/createassetdialog.cpp
Outdated
| @@ -170,7 +216,13 @@ void CreateAssetDialog::ipfsStateChanged() | |||
|
|
|||
| void CreateAssetDialog::checkAvailabilityClicked() | |||
| { | |||
| QString name = ui->nameText->text(); | |||
| QString name = ""; | |||
There was a problem hiding this comment.
these lines duplicate the block starting at line 160 -- could possibly be consolidated
There was a problem hiding this comment.
Consolidated into function
src/qt/createassetdialog.cpp
Outdated
| @@ -244,8 +326,14 @@ void CreateAssetDialog::onCreateAssetClicked() | |||
| } else { | |||
| address = ui->addressText->text(); | |||
| } | |||
| QString name = ""; | |||
There was a problem hiding this comment.
Consolidated into function
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.