Refactor the RefSet value type into a structure type #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copied from Perforce Change: 194908
… tests. Copied from Perforce Change: 194918
… tests now passes. Copied from Perforce Change: 194925
Copied from Perforce Change: 194934
…set confusion in design documents. Copied from Perforce Change: 194935
Copied from Perforce Change: 195982
Copied from Perforce Change: 195987
Copied from Perforce Change: 195994
…o test with CI and prepare for review.
rptb1
commented
Jan 27, 2023
rptb1
commented
Jan 27, 2023
rptb1
commented
Jan 27, 2023
rptb1
commented
Jan 27, 2023
rptb1
commented
Jan 27, 2023
…y in ScanStateUpdateSummary.
… and "refsets" (conservative approximations) in design and naming.
|
4d74b92 shows that the terms "summary", "reference set", "zones", and "zone set" are conflated in design, comments, and naming. This needs careful search and clean-up. They are separated by the work on this branch. |
|
A note for review: the differences on the remember-time-3 branch are a source document for this work. |
thejayps
added
the
needs analaysis
thejayps
added
performance
|
We believe this is essential. We still need to do experiments to back this up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As https://www.ravenbrook.com/project/mps/branch/ says:
This is refactoring work that should not have any external effect on the MPS. Its purpose is to lay the foundation for inclusion of age (or other) information in the remembered set, to reduce unnecessary scanning and improve performance (#136 solution 3).
The reason this is its own branch and pull request is that it's a delicate change that needs careful review and testing. Adding age information to the remembered set is also a delicate change that will need careful review and testing. Trying to do both at once is very risky.