Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that the jump buffer is appropriately aligned. #86

Open
wants to merge 1 commit into
base: 59-memory-aware
Choose a base branch
from

Conversation

gareth-rees
Copy link
Member

@gareth-rees gareth-rees commented Dec 27, 2022

The stack capturing mechanism in STACK_CONTEXT_BEGIN puts the StackContextStruct on the stack, where it will later be scanned using TraceScanArea. The jumpBuffer must be allocated on the stack at an address with suitable alignment so that TraceScanArea will correctly fix any addresses therein. On platform XCA6LL, jmp_buf is declared as an array of int, which has 4-byte alignment, but we need it to have 8-byte alignment in order to correctly interpret the contents.

This addresses fifteen of the seventeen MMQA test failures in issue #84.

@rptb1 rptb1 added the arch.a6 Relates to arm64/aarch64 label Jan 17, 2023
@rptb1 rptb1 added the blocked Unable to proceed. See comment for reason. label Feb 14, 2023
@thejayps
Copy link
Contributor

@rptb1 : blocked because we are waiting for Apple Silicon CI to be available. This will come from #145.

@thejayps thejayps added the essential Will cause failure to meet customer requirements. Assign resources. label Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arch.a6 Relates to arm64/aarch64 blocked Unable to proceed. See comment for reason. essential Will cause failure to meet customer requirements. Assign resources.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants