Fallback to known font dir paths if none were loaded via fontconfig #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Honestly, I would rather remove fontconfig support altogether. People should stop using |
RazrFalcon
reviewed
Sep 4, 2024
MoSal
force-pushed
the
fontconfig_fallback
branch
from
2be2f3c to
ea9956c
Compare
|
Fails to build. |
In cases where parsing fontconfig conf files may fail, or no font dirs would be loaded for some other reason, it could be useful to fallback to the non-fontconfig mechanism of trying to load from some fixed known font dir paths. A case where a distribution botched fontconfig conf files with an upgrade was seen in pop-os/cosmic-term#323. And while Nix users in particular may not have benefited from this change. I think the scenario is plausible enough to occur via distribution or user error. The benefit of things probably working, at least partially, with and without fontconfig's help is a big plus IMHO. Signed-off-by: Mohammad AlSaleh <CE.Mohammad.AlSaleh@gmail.com>
MoSal
force-pushed
the
fontconfig_fallback
branch
from
ea9956c to
e8aed04
Compare
Apologies. My bad. |
|
Thanks! |
|
A version bump would be appreciated. |
|
Done. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In cases where parsing fontconfig conf files may fail, or no font dirs
would be loaded for some other reason, it could be useful to fallback
to the non-fontconfig mechanism of trying to load from some fixed
known font dir paths.
A case where a distribution botched fontconfig conf files with an
upgrade was seen in pop-os/cosmic-term#323. And while Nix users in
particular may not have benefited from this change. I think
the scenario is plausible enough to occur via distribution or user
error.
The benefit of things probably working, at least partially, with and
without fontconfig's help is a big plus IMHO.